Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update README with instruction #40

Open
hozza opened this issue Nov 2, 2023 · 0 comments
Open

Update README with instruction #40

hozza opened this issue Nov 2, 2023 · 0 comments

Comments

@hozza
Copy link

hozza commented Nov 2, 2023

First of call, great plugin! 👍 🥇

While tinkering I noticed that the the README could do with an update in the New Highlights section as well as the installation instruction #34.

It currently reads as though all the params for adding a new comment type including color.name and color.foreground should be applied in the user settings. When it seems the color info is applied in the manual theme override section in theme_name.sublime-color-scheme as

{
  "name": "REVIEW COMMENTS",
  "scope": "comments.review",
  "foreground": "var(undefined_comment)",
  "background": "var(--background)",
},

And the new highlight settings are applied in the user settings for the plugin:

"REVIEW": {
  "scope": "comments.review",
  "identifier": "REVIEW",
  "ignorecase": true,
},
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant