Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fixing further issues, #25

Closed
wants to merge 2 commits into from
Closed

fixing further issues, #25

wants to merge 2 commits into from

Conversation

EttnerAndreas
Copy link
Contributor

add THICK dataset
add further titanic description
add wine description
add nasa description
change redCards URL

fixes #6 , fixes #8 , fixes #14 , fixes #15 , fixes #16 ,
probably ass well Issue22 depends, if variables boat and bodys should be removed, explanation is added

add THICK dataset
add further titanic description
add wine description
add nasa description
change redCards URL
@florianhartig
Copy link
Member

I'm still getting a large number of warnings when checking this, including:

  1. Directly when installing, I get

Error in get(genname, envir = envir) : object 'testthat_print' not found

  1. When checking, there is various

\examples lines wider than 100 characters:

checking for missing documentation entries ... WARNING
Undocumented code objects:
‘anolisData’ ‘anolisTree’
Undocumented data sets:
‘anolisData’ ‘anolisTree’
All user-level objects in a package should have documentation entries.
See chapter ‘Writing R documentation files’ in the ‘Writing R
Extensions’ manual.

checking for unstated dependencies in examples ... WARNING
'::' or ':::' import not declared from: ‘missRanger’
'library' or 'require' calls not declared from:
‘dplyr’ ‘missRanger’ ‘ranger’

checking data for non-ASCII characters ... WARNING
Warning: found non-ASCII strings

checking examples ... ERROR
Running examples in ‘EcoData-Ex.R’ failed
The error most likely occurred in:

base::assign(".ptime", proc.time(), pos = "CheckExEnv")

Name: redCards

Title: redCards

Aliases: redCards

Keywords: datasets

** Examples

Is this really running through for you when you use RStudio check?

removing non ASCII character in redCards
@EttnerAndreas
Copy link
Contributor Author

@florianhartig I naively thought it might be a good idea to just add them and fix existing bugs in the GitAction branch, and did not reallise that redCards datasets contained massive non-ASCII character.
Anyway, I am currently trying to fix this and will create a PR then.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants