Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Why OpenAPI? #26

Open
jcorry opened this issue Mar 28, 2021 · 2 comments
Open

Why OpenAPI? #26

jcorry opened this issue Mar 28, 2021 · 2 comments

Comments

@jcorry
Copy link

jcorry commented Mar 28, 2021

I'm curious what motivated openAPI and it's code generator?

It seems like all of the functionality provided there could be delivered by:

I am a fan of grpc-web for consuming gRPC services with a Vue client, but realize a REST analog is often useful too.

It seems like it would be simpler and with less overhead to use tools from within the same gRPC ecosystem.

I am really enjoying the book! Thank you so much for publishing all of this!

@m110
Copy link
Member

m110 commented Mar 28, 2021

Hey @jcorry!

The reason is simply we didn't use gRPC this way yet. The gRPC gateway seems to totally make sense for the kind of communication we've created. On the other hand, REST is very popular for frontend/backend communication, and we wanted to base Wild Workouts on technologies everyone is familiar with.

We might introduce it in the future to simplify the API, but first we'll be focusing on more strategic patterns. Thanks a lot for bringing it up and I'm glad you liked the book! :)

@m110
Copy link
Member

m110 commented Mar 28, 2021

Actually, adding gRPC gateway would be a great example of how Clean Architecture enables such changes. In Wild Workouts, it would be just extending the ports layer. :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants