Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Build reusable button component to close pop-up modals #334

Open
intelagense opened this issue Feb 14, 2023 · 8 comments
Open

Build reusable button component to close pop-up modals #334

intelagense opened this issue Feb 14, 2023 · 8 comments
Labels
Accessibility Issues impacting the accessibility of the project Low Priority This is for issues that may or may not be important, and do not need to be solved quickly.

Comments

@intelagense
Copy link
Member

intelagense commented Feb 14, 2023 •
edited
Loading

Please provide a summary of the feature

Currently, the close buttons are centered at the top of the modals and says close
Suggest turning the button into a reusable React component moving the close button to the right side of the modal and turning it into an X icon to match typical expected behavior.

Are there any potential issues you foresee with this feature

Needs to match the styling in #17

Is this feature related to any current or past issues? Please provide the

This was noticed with PR #333 into issue #303

Additional context

Add any other context or screenshots about the feature request here.

Which Branch should this fix be Pulled into?

PR into [development]

If you're interested in working on this feature, please comment so you can be assigned
@intelagense intelagense added enhancement New feature or request Accessibility Issues impacting the accessibility of the project labels Feb 14, 2023
@colinborows
Copy link

interested, please assign.

@intelagense intelagense changed the title Style close buttons to Build reusable button component to close pop-up modals Feb 14, 2023
@intelagense intelagense added Low Priority This is for issues that may or may not be important, and do not need to be solved quickly. and removed enhancement New feature or request labels Feb 14, 2023
@Caleb-Cohen Caleb-Cohen moved this to In Progress in Together General Issues Feb 21, 2023
@Caleb-Cohen
Copy link
Member

Hey @colinborows I'm just checking in on this, thank ya!

@colinborows
Copy link

Hey! After a slight diversion, I am back on the React grind and working on this issue. I have been learning more about contexts and considering how best to implement this. I will reach out to the team with some questions this week.

@colinborows
Copy link

colinborows commented Mar 14, 2023 •
edited
Loading

Update - reached a roadblock with this. Will be reaching out for help tomorrow.

@Caleb-Cohen
Copy link
Member

Update - reached a roadblock with this. Will be reaching out for help tomorrow.

Sounds good. Did you get the help you were looking for?

@luciousmc
Copy link
Contributor

@colinborows Caleb mentioned you might need some help with this issue. Feel free to reach out to me on discord @brotahman and we can tackle it 😀

@colinborows
Copy link

Update on this - @luciousmc has been kind enough to help me out with this over the past few days and figure out the best option. Now moving forward creating a reusable button that takes in an icon and a function, rather than simply a close button.

@Caleb-Cohen
Copy link
Member

Update on this - @luciousmc has been kind enough to help me out with this over the past few days and figure out the best option. Now moving forward creating a reusable button that takes in an icon and a function, rather than simply a close button.

Anything we can help ya with?

@Caleb-Cohen Caleb-Cohen moved this from In Progress to Todo in Together General Issues Jul 25, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Accessibility Issues impacting the accessibility of the project Low Priority This is for issues that may or may not be important, and do not need to be solved quickly.
Projects
Together General Issues
Status: Todo
Milestone
No milestone
Development

No branches or pull requests
4 participants
@intelagense @luciousmc @Caleb-Cohen @colinborows