Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move away from tonic's TLS & Connection libraries #1235

Open
allada opened this issue Aug 5, 2024 · 1 comment
Open

Move away from tonic's TLS & Connection libraries #1235

allada opened this issue Aug 5, 2024 · 1 comment
Assignees
Labels
enhancement New feature or request

Comments

@allada
Copy link
Member

allada commented Aug 5, 2024

In order to get a bit lower and control the network flow, we need to remove tonic's TLS & connection apis/libraries and talk directly to hyper.

The big advantage of doing this is that we will then be able to not be required to talk over TLS channels and can talk over more complex channels, like file sockets. In this specific case, we want to have a custom HTTP upgrade, take the underlying IO socket, then reverse the client/server relationships for the scheduler/worker management. Doing so allows the worker to connect to a scheduler, but then have the worker be the service and the scheduler be the client according to GRPC, but still have all HTTP & TLS securities for the initial connection.

@allada allada self-assigned this Aug 5, 2024
@aaronmondal
Copy link
Member

I'm a big fan of this. When I did the hyper 1.x migration I kept thinking that many of the existing tonic wrapping logic is likely obsolete.

@aaronmondal aaronmondal added the enhancement New feature or request label Aug 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants