💎 Support digest_function in GrpcStore

[bclark8923]

When using an alternative hash function to the default (sha256), GRPC store doesn't receive which hash function to use.

[MarcusSorealheis]

If you are looking to solve this issue, look into resource_info.rs. It predates our support
for Blake3.

[aleksdmladenovic]

I will work on this issue. cc: @MarcusSorealheis, @allada, @bclark8923.

[aleksdmladenovic]

Hi, @bclark8923.

I looked over details of this issue and I have some things unclear about this issue.

FYI, from this PR, we now detect digest function automatically from the request.

And there is code for GrpcStore receiving digest_function from ActiveOriginContext in grpc_store.rs.

nativelink/nativelink-store/src/grpc_store.rs

Lines 438 to 442 in 8d957a5

	digest_function: ActiveOriginContext::get_value(&ACTIVE_HASHER_FUNC)
	.err_tip(|| "In get_action_from_store")?
	.map_or_else(default_digest_hasher_func, |v| *v)
	.proto_digest_func()
	.into(),

nativelink/nativelink-store/src/grpc_store.rs

Lines 494 to 498 in 8d957a5

	digest_function: ActiveOriginContext::get_value(&ACTIVE_HASHER_FUNC)
	.err_tip(|| "In get_action_from_store")?
	.map_or_else(default_digest_hasher_func, |v| *v)
	.proto_digest_func()
	.into(),

nativelink/nativelink-store/src/grpc_store.rs

Lines 541 to 545 in 8d957a5

	digest_function: ActiveOriginContext::get_value(&ACTIVE_HASHER_FUNC)
	.err_tip(|| "In GrpcStore::has_with_results")?
	.map_or_else(default_digest_hasher_func, |v| *v)
	.proto_digest_func()
	.into(),

And just fyi, while I was trying to evaluate this issue, I found out that there were no test files for testing GrpcStore feature.

Did we omit this for specific purpose or just missing and need to be added later?

And I hope you to make it clear how you caught this issue and how you tested.

Thanks.

cc: @allada, @MarcusSorealheis

[MarcusSorealheis]

@aleksdmladenovic if there is no test we need to write one.

[MarcusSorealheis]

/bounty $1000

[algora-pbc]

💎 $1,000 bounty • TraceMachina

Steps to solve:

1. Start working: Comment /attempt #1325 with your implementation plan
2. Submit work: Create a pull request including /claim #1325 in the PR body to claim the bounty
3. Receive payment: 100% of the bounty is received 2-5 days post-reward. Make sure you are eligible for payouts

Thank you for contributing to TraceMachina/nativelink!

Add a bounty • Share on socials

Attempt	Started (GMT+0)	Solution
🟢 @asr2003	Nov 21, 2024, 5:20:15 AM	#1548

[MarcusSorealheis]

more guidance here: https://gist.github.com/MarcusSorealheis/17307f41b6c632cb751c397280c70ed4

[asr2003]

@MarcusSorealheis This is Sahithi from Algora expert community! I would like to connect and tackle this issue and I have gone through the program guidelines attached above. Well, I need to discuss my approach before I design document what's I am thinking of in Slack. Can we continue discussion in a draft design PR or in Slack. Happy to contribute to nativelink :)

Can I get this issue assigned?

/attempt #1325

Algora profile	Completed bounties	Tech	Active attempts	Options
@asr2003	9 bounties from 4 projects	Scala, Rust, Go & more		Cancel attempt

[MarcusSorealheis]

@asr2003 you need to start with. Design document per the details in the gist above.

[asr2003]

@MarcusSorealheis Here's my draft of design doc for this issue.
https://docs.google.com/document/d/1VI3OwfBNgIeF_gJ38yILoH-WgJIrVwOz/

I am happy to incorporate any suggestions and feedback :)

[MarcusSorealheis]

Could you include it in the Slack as well? Here is the Slack: https://join.slack.com/t/nativelink/shared_invite/zt-281qk1ho0-krT7HfTUIYfQMdwflRuq7A

…

On Thu, Nov 21, 2024 at 9:17 AM asr2003 ***@***.***> wrote: @MarcusSorealheis <https://github.com/MarcusSorealheis> Here's my draft of design doc for this issue. https://docs.google.com/document/d/1VI3OwfBNgIeF_gJ38yILoH-WgJIrVwOz/ I am happy to incorporate any suggestions and feedback :) — Reply to this email directly, view it on GitHub <#1325 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AAR6TSDVHNLP4W2GLRHMGTT2BYITPAVCNFSM6AAAAABNXQBKZWVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDIOJRHAZDSMJQGQ> . You are receiving this because you were mentioned.Message ID: ***@***.***>

-- Marcus Eagan

[algora-pbc]

💡 @asr2003 submitted a pull request that claims the bounty. You can visit your bounty board to reward.