Gemfile: move asset gems to 'default' (rm 'assets' section) #3066
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Looking at the test failure, it seems to be failing because GH dropped support for docker compose v1. As noted there, the primary change required is |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi @ZeiP 👋 😎
I'm no RoR expert, but this seems like the "right" fix for #3065?! My rationale is here.
If you don't like this approach please share your preferred path and I'll have another stab. I'd also be really interested in your rationale.
Update
Gemfile:assetssectiondefaultFYI I haven't explicitly tested as per
CONTRIBUTING.md.I have tested in a chroot during TKL Tracks app v18.1 update dev. I'll also do a final pre-release smoke test. Others have also confirmed a similar "fix" in #3065. Hopefully that's good enough?