Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

SnapshotVolumeAction is not well tested #35

Open
Dermah opened this issue Feb 12, 2016 · 1 comment
Open

SnapshotVolumeAction is not well tested #35

Dermah opened this issue Feb 12, 2016 · 1 comment
Labels
technical debt

Comments

@Dermah
Copy link
Member

Dermah commented Feb 12, 2016

SnapshotVolumeAction does some funky stuff with timers and self referential promises that makes it difficult to test properly. It needs to be re-engineered, or a way to test it needs to be figured out.
@Dermah
Copy link
Member Author

Dermah commented Feb 15, 2016

657418d demonstrates a slightly simpler Promise chain with retries that may make testing easier

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
technical debt
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@Dermah