Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rederive or remove TasmObject implementation for MmrMembershipProof #110

Open
Sword-Smith opened this issue Jul 18, 2024 · 0 comments
Open

Comments

@Sword-Smith
Copy link
Contributor

Since leaf_index is removed from MmrMembershipProof upstream in twenty-first, we need to update the auto-generated TasmObject implementation of this structure, located in (tasm-lib/src/structure/auto_generated_tasm_object_implementations.rs). Alternatively, we could delete the implementation all together, since the structure now only contains one field, the authentication path.

#[derive(Debug, Clone, Serialize, Deserialize, GetSize, BFieldCodec, Arbitrary)]
pub struct MmrMembershipProof<H>
where
    H: AlgebraicHasher + Sized,
{
    pub authentication_path: Vec<Digest>,
    #[bfield_codec(ignore)]
    pub _hasher: PhantomData<H>,
}

Note that this should not be done before the upstream triton-vm is updated, since the current triton-vm version still uses the MmrMembershipProof structure that contains the leaf index.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant