Some questions

[TheDovahkiin97]

Hello, I finally tried it out and I'm very impressed!

But I have some questions:

1. Are there any graphics options?
2. How do I display my fps?
3. Can I somehow turn off the light blue distant "fog"? I know it's vanilla-like but imho it does'nt make sense when you can render the whole map.
4. I installed Reportversion 2.6.0.0, Playerkit 2.6f and Systempack 1.8. Does this change anything? Are they even active?
5. How exactly do use the "-game:<modfile.init>" command? I tried the following to play with l'hiver:
   a) "-game:<LHE204_DE.init>"
   b) "-game:<LHE204_DE.ini>"
   c) "-game:LHE204_DE.init"
   d) "-game:LHE204_DE.ini"
   but none worked.

Thanks in advance

[Try]

Hi, @TheDovahkiin97 !

Are there any graphics options?

"cloud shadows" is remapped to SSAO
"radial fog" is remapped to light-shaft scattering
-rt 0, in command line is to disable ray-tracing
-ms 0, in command line is to disable mesh-shading (this is not a real graphics feature, more to addres possible issues)

How do I display my fps?

Same as vanilla game : marvin -> toggle frame

Can I somehow turn off the light blue distant "fog"?

Hm, now sure what this is about. There is some fog - sure, but shouldn't be a much. Can you share screenshoot, to illustrate the problem?

I installed Reportversion 2.6.0.0, Playerkit 2.6f and Systempack 1.8. Does this change anything? Are they even active?

Those patches are design to be injected into original gorhic2.exe 32-bit binary and fix issue that are not in OpenGothic to begin with.
Having them around should cause no effect.

How exactly do use the "-game:<modfile.init>" command?

Those are primarily for GothicStarter. So, if you replace original Gothic2.exe with OpenGothic (and rename exe), than starter can communicate with to opengothic and notify what mod is needed.

As for manual usage, here is command line that I've been using for KoM:
-g "C:\Program Files (x86)\Steam\steamapps\common\TheChroniclesOfMyrtana" -game:TheChroniclesOfMyrtana.ini
(sorry, have no L'hiver as mode, but should be same)

[TheDovahkiin97]

Okay no problem I'll wait ✌️

But will you implement an option to turn off fog?

[lmichaelis]

LHiver204_DE_22-06-20.exe

I've give it a run locally - seems mod uses more move slots in AI than allowed. CC @lmichaelis, apparently in scripts there is:

CLASS C_FightAI 
{
	VAR INT move[7]; // instead of 6
};

Hm, there is a solution but it's not very elegant. First though, I re-checked Gothic's and Gothic II's FIGHTAI.DAT and I can say with certainty that 6 is the correct number of C_FIGHTAI.MOVEs:

Gothic 1

00000012 <C_FIGHTAI>
	Name: C_FIGHTAI
	Address: ffffffff
	Size: 1
	Type: class
	Generated: No
	Flags:
		Const: No
		Return: No
		Member: No
		Extern: No
		Merged: No
	File Index: 0
	Line Start: 26
	Line Count: 4
	Char Start: 1069
	Char Count: 51
	Class Size: 24
	Definition:
		class C_FIGHTAI {
			var int MOVE[6];
		};

Gothic 2

00000014 <C_FIGHTAI>
	Name: C_FIGHTAI
	Address: ffffffff
	Size: 1
	Type: class
	Generated: No
	Flags:
		Const: No
		Return: No
		Member: No
		Extern: No
		Merged: No
	File Index: 0
	Line Start: 33
	Line Count: 4
	Char Start: 1474
	Char Count: 51
	Class Size: 24
	Definition:
		class C_FIGHTAI {
			var int MOVE[6];
		};

L'Hiver (at least in this version) actually does use 7 FIGHTAI.MOVEs. That's a rather weird choice if you ask me.

L'Hiver

00000014 <C_FIGHTAI>
	Name: C_FIGHTAI
	Address: ffffffff
	Size: 1
	Type: class
	Generated: No
	Flags:
		Const: No
		Return: No
		Member: No
		Extern: No
		Merged: No
	File Index: 0
	Line Start: 22
	Line Count: 4
	Char Start: 554
	Char Count: 40
	Class Size: 28
	Definition:
		class C_FIGHTAI {
			var int MOVE[7];
		};

A solution could be to actually just up the number of MOVEs supported by phoenix since scripts that don't use that many just don't care. What do you think @Try? Should I just up that number in phoenix or should I rather provide a way for you to alter it using #defines or templates?

[Try]

@lmichaelis , my assumption is that Vanilla can't really work with this case eider, and changing layout of engine-classes is UB.
For this case, trimming script array size and print warning is probably good solution.

[Try]

But will you implement an option to turn off fog?

Well, eventually :)
Probably will have to introduce some config file like OpenGothic.ini, since we running out of traditional menu settings

[lmichaelis]

my assumption is that Vanilla can't really work with this case eider

Yeah that does seem to be the case, poking at a decomp.

trimming script array size and print warning is probably good solution.

That might work. phoenix will fail accessing the element at that index and throw an illegal_index_access exception which can be handled by the VM exception handler (which is current set to the default lenient_vm_exception_handler).

OpenGothic/game/game/gamescript.cpp

Lines 68 to 70 in 1006d12

	phoenix::register_all_script_classes(vm);
	vm.register_exception_handler(phoenix::lenient_vm_exception_handler);
	Gothic::inst().setupVmCommonApi(vm);

[toolatetotheparty]

3. Can I somehow turn off the light blue distant "fog"? I know it's vanilla-like but imho it does'nt make sense when you can render the whole map.

The tint of the fog, ideally, should take the color of the sky, so during the daylight it hould have a blue tint. It would be nice to adjust the "fog-min" and "fog-max" distance values, though, since the scale of the world is small and aerial perspective should artistically scale with it.

[Try]

should take the color of the sky,

Currently fog is based on UE 4.27 way of doing physical fog, so most stuff from their page is applicable:
https://docs.unrealengine.com/4.27/en-US/BuildingWorlds/FogEffects/VolumetricFog/

Currently, in OpenGothic

const float viewDistanceScale      = 20 - this is to take care of small world size

const vec3  rayleighScatteringBase = vec3(0.175, 0.409, 1.0) / 1e6;
const float rayleighAbsorptionBase = 0.0;

const float mieScatteringBase      = 3.996 / 1e6;
const float mieAbsorptionBase      = 4.40  / 1e6;

const vec3  ozoneAbsorptionBase    = vec3(0.650, 1.881, .085) / 1e6;

Scattering term are also multiplied by cloud concentration on a level to address Valey of mines look.