Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Architecture: forking and child documents #344

Open
YousefED opened this issue Jul 13, 2023 · 0 comments
Open

Architecture: forking and child documents #344

YousefED opened this issue Jul 13, 2023 · 0 comments

Comments

@YousefED
Copy link
Collaborator

There are several issues with the current design of forking and nested documents:

Currently:

  • Documents can have multiple parents
  • Access is determined by access to the document, or the most restrictive access level of its parents
  • Child reference are stored parent->child

The idea behind this was that for a real "wysiwyg"-experience, users should always be able to modify anything in a workspace, and "create a copy" when do don't have write access. We might need to revisit this vision.

Issues:

  • It's not possible to view sync / fork-required status of a workspace. This means that if you create a new document and add it to the root of a project you don't have write-access for, you won't be able to see that you don't have write access.
  • If you add someone else's document as child to one of your own docs, you can probably restrict the author's access to that doc by changing the access level of the parent (not validated)
  • it might be possible to create circular parent / child structures

Possible solutions might be in direction of:

  • storing hierarchical info in child->parent
  • don't allow multiple parents

For now, we'll hide the "add a page" button unless you're on your own workspace

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant