Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updating to v5.4.0 led to a change in the order in which the files are concatenated #347

Open
thorn0 opened this issue Mar 25, 2016 · 2 comments

Comments

@thorn0
Copy link
Contributor

thorn0 commented Mar 25, 2016

In my project, tsconfig.json with the outFile option is used. With v5.3.2, the files in the project root went first in the output file, which was exactly what is needed. But after the update, the order has changed. The files seem to be sorted by their name now, regardless their location. My project was broken, and I had to stick with 5.3.2.

So, is this an intended change?

How can I enforce the order so that the files from the root would always be first even if I switch to a newer version of grunt-ts?

Actually, in this case (when tsconfig.json exists), I think grunt-ts shouldn't have any influence on the concatenation order at all. If I run tsc directly from the command line, I get the same results as with 5.3.2.

@nycdotnet
Copy link
Contributor

Hi, we did change that code but this was not one of the intended results. I also think grunt-ts should respect the order used by tsc.

@thorn0
Copy link
Contributor Author

thorn0 commented Sep 23, 2016

Related issue: microsoft/TypeScript#8776 ('File enumeration order in directory-scanning mode should be deterministic')

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants