-
Notifications
You must be signed in to change notification settings - Fork 499
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Spectrum Display Improvement #149
Comments
|
If you can add one, I'll appreciate so much. :) |
I implemented a Blackman-Harris window, but I won’t make a pull request for it because this is a clear regression from a productivity point of view. The reason is simple: with a rectangular window, the main lobe of a frequency component is very sharp (and the side lobes quite high but this is not a problem here), whereas the main lobe of a more sophisticated window is much wider, and it looks blurry when displayed. So voiced components are less obvious to detect visually. |
Thanks for your contribution again. I partly agree with you. Blackman-Harris windows looks a bit blurry. But it improves the SNR. If a source audio has a lot of noise, Blackman-Harris may be a better choice. You can add an option if you want, let user to decide. Options are better than nothing. |
Based on Spectrum display improvement #94, there are still some issues.
Look at the underlined part, it seems strange. As far as I know, the performance above is similar to
Hamming
window funtion, screenshot in Adobe Audition -Hamming
window function:FFmpeg provides varieties of window functions, see FFmpeg filters - showfreqs. For reference, Adobe Audition uses Blackman-Harris (i.e.
bharris
) as the default.:) The two enhancement requests are in order to improve efficiency. I lack cpp development experience so I can only raise a issue instead of PR. 😢
The text was updated successfully, but these errors were encountered: