Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

PULL_REQUEST_TEMPLATE #211

Closed
11 tasks
larslemos opened this issue Aug 23, 2021 · 1 comment
Closed
11 tasks

PULL_REQUEST_TEMPLATE #211

larslemos opened this issue Aug 23, 2021 · 1 comment

Comments

@larslemos
Copy link
Contributor

While Issuing a PR, as a Team to ensure proper documentation and best practices. Follow the below Check List
What is the Scope of the PR

Did you?

  • Breaking change (fix or feature that would cause existing functionality to change)
  • I have updated the documentation accordingly
  • I have added tests to cover my changes

Collaboration

  • Assign 2+ colleagues to your PR
  • Ensure the CI Checks Pass before Merge
  • Follow up with updating the Ticket associated to the Task
@larslemos larslemos pinned this issue Aug 23, 2021
@smallgod
Copy link
Member

thanks @larslemos

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@smallgod @larslemos @pirupius