Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rebuilding Links, Failed to execute command #12

Open
trusktr opened this issue Oct 12, 2020 · 0 comments
Open

Rebuilding Links, Failed to execute command #12

trusktr opened this issue Oct 12, 2020 · 0 comments

Comments

@trusktr
Copy link

trusktr commented Oct 12, 2020

Looks like nsi tries to npm link the linked packages that it unlinked, but npm link isn't always the way that the packages were originally linked. The linked packages may be linked in any fashion, for example using good ol' ln -s ../../path/to/some-package.

So because of that, we get an error like this:

Rebuilding Links
Failed to execute command: Error: Command failed: cd /home/trusktr/src/lume+lume/apps/website && npm link @lume/cli lume

but @lume/cli and lume are not linked to the global location like normal (i.e. npm link was not ran in those packages in order to link the to the global location).

I think what nsi should do instead is simply copy the link files, run the npm install, then finally move the link files back into their original locations (forcefully overwriting folders if needed).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant