Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

val or hdt_michigan? #19

Open
PeterMitrano opened this issue Jan 19, 2021 · 2 comments
Open

val or hdt_michigan? #19

PeterMitrano opened this issue Jan 19, 2021 · 2 comments

Comments

@PeterMitrano
Copy link
Contributor

This is probably the single biggest naming problem in our entire code base. All the code HDT wrote calls it "hdt_mihigan" but we have used val in a lot of places. Accepting that it's called hdt_michigan in code is the far easier option, and so we could go forward with this convention. We can still cal it val casually in that case. Or we can use val in code going forward, and eventually drop or rename places it was called hdt_michigan. I'm personally in favor of keeping hdt_michigan but I could be convinced otherwise.

@bsaund
Copy link
Contributor

bsaund commented Jan 19, 2021

Starting from scratch, I'd rather call it "val"

@PeterMitrano
Copy link
Contributor Author

I've just made this problem worse by calling it "husky" in some places...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants