Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

distribute_for_susong1999 doesn't run when were not gridded and adjusting for undercatch #132

Open
micahjohnson150 opened this issue Jan 15, 2020 · 0 comments
Labels

Comments

@micahjohnson150
Copy link
Contributor

I am adjusting the code in awsm and the tests there do not adjust for undercatch. For station data this will skip over the distribute function.

This is because in (distribute/precipitation.py Line 289)[https://github.com/USDA-ARS-NWRC/smrf/blob/0414238eddeb5b94e20213a2087c5da9aa499b79/smrf/distribute/precipitation.py#L289 is tabbed 1x too many.

This results in an attribute not found right away in model_framework.py when we refer to last_storm_basin

DEBUG:smrf.distribute.precipitation:1986-02-17 01:00:00+00:00 Distributing all precip INFO:awsm.framework.framework:SMRF closed --> 2020-01-15 10:43:30.056306 INFO:awsm.framework.framework:AWSM closed --> 2020-01-15 10:43:30.056460 Traceback (most recent call last): File "/home/micahjohnson/projects/venv/awsmenv/bin/awsm", line 6, in <module> exec(compile(open(__file__).read(), __file__, 'exec')) File "/home/micahjohnson/projects/awsm/scripts/awsm", line 27, in <module> run() File "/home/micahjohnson/projects/awsm/scripts/awsm", line 24, in run run_awsm(configFile) File "/home/micahjohnson/projects/awsm/awsm/framework/framework.py", line 878, in run_awsm a.runSmrf() File "/home/micahjohnson/projects/awsm/awsm/framework/framework.py", line 431, in runSmrf smin.smrfMEAS(self) File "/home/micahjohnson/projects/awsm/awsm/interface/interface.py", line 93, in smrfMEAS s.distributeData() File "/home/micahjohnson/projects/smrf/smrf/framework/model_framework.py", line 491, in distributeData self.distributeData_single() File "/home/micahjohnson/projects/smrf/smrf/framework/model_framework.py", line 567, in distributeData_single print(self.distribute['precip'].last_storm_day_basin) AttributeError: 'ppt' object has no attribute 'last_storm_day_basin'

micahjohnson150 added a commit that referenced this issue Jan 15, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

1 participant