Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Config file change log in application #143

Open
scotthavens opened this issue Mar 19, 2020 · 3 comments
Open

Config file change log in application #143

scotthavens opened this issue Mar 19, 2020 · 3 comments

Comments

@scotthavens
Copy link
Contributor

scotthavens commented Mar 19, 2020

Converting the gold config file (for the station data run tests/RME/gold) over to the new parameters brought about a few gotchas and issues. Converting the file with inicheck produced multiple errors in the new config file that required addressing.

  • air_temp: grid_mask and grid_method
  • vapor_pressure: grid_mask and grid_method
  • precip: set the rescaling method since there is only one if distribute_drifts is True
  • cloud_Factor: only had grid_method and nothing else, should have had the defaults at minimum
  • thermal: grid_local

Converting the gold config file (for the HRRR data run tests/RME/gold_hrrr)

  • gridded: wrf_file and netcdf_file present
  • air_temp: kriging parameters present
  • vapor_pressure: kriging parameters present
  • wind: maxus_file present, kriging parameters and wind ninja parameters
  • cloud_factor: only krig_coordinate_type and none of the gridded interp

Seem like working on the recipes will help.

@micahjohnson150
Copy link
Contributor

I am not surprised there are issues with the changelog stuff.

I don't quite follow the problem though. Are you saying you had to add grid_mask and grid_method in?
Was vapor_pressure missing completely?

@scotthavens
Copy link
Contributor Author

Sorry, probably wasn't that clear. Those were extra fields that were in each section. vapor_pressure also had the grid methods, don't know why it showed up.

cloud_factor was missing almost everything.

@micahjohnson150
Copy link
Contributor

The cloud factor is the most peculiar one to me. It should be there by all accounts. inicheck sees the full core config entry so I know its not a typo gone under the radar. When I ask for the recipes it inicheck sees that it uses the cloud_factor_recipe. So why is there nothing else in there....

Here is what I did to replicate. Let me know if this is different than what you did.

inicheck -m smrf -f tests/RME/gold/config.ini --change -w

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants