Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

A buffer zone of 0.25 angstrom in template browser may introduce line templates which are not present in the data cube #101

Open
yjzhu-solar opened this issue Sep 5, 2024 · 1 comment

Comments

@yjzhu-solar
Copy link

It is convenient to check and select available lines through the eis_browse_template GUI. However, sometimes a buffer of 0.25 angstrom in the maximum and minimum wavelengths may introduce additional lines not included in the dataset. For example, in eis_20071112_011726.head.h5, window 15 has a wvl_max = 264.10, but the template browser still includes the S X 264.23 line in the available templates. Is it a good idea to downsize this buffer zone?

@MJWeberg
Copy link
Collaborator

Excellent point! To be honest, I am not entirely sure why the buffer is so large. I think the intent is to show all templates which overlap each data window. This can be useful in the case of multi-component fits where one of the lines falls outside the data window.

E.g., in your example file, window 3 has a wavelength range of 187.69 to 188.738 and one of the templates available is a three component fit with Fe IX 188.497, Si XI 188.675, & Ar XI 188.806 (which is outside the data window)

However, this behavior can just cause confusion and, as you pointed out, can return templates that are not relevant or useful. I agree that we should reduce the buffer value and maybe also filter out single gaussian templates that are mostly outside the window. While we are at it, we should probably also sort the list by template wavelength, rather than element (since the current method can make multi component fits hard to see).

Thanks for bringing this to our attention!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants