Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change "All" Endpoint Timeouts #224 #235

Open
wants to merge 5 commits into
base: develop
Choose a base branch
from

Conversation

armansarder
Copy link

… the system to gather the data in time, and that 30s wasnt outrageously long time. Please let me know if I completed the task properly or if there should be any more changes thanks.

… the system to gather the data in time, and that 30s wasnt outrageously long time. Please let me know if I completed the task properly or if there should be any more changes thanks.
@jpahm jpahm self-requested a review November 4, 2024 01:28
@jpahm
Copy link
Contributor

jpahm commented Nov 4, 2024

Could you test and make changes to CourseAll as well? Thanks!

@jpahm jpahm changed the title I changed the timeout time from 10s to 30s. I figured 30s would allow… Change "All" Endpoint Timeouts #224 Nov 4, 2024
@jpahm jpahm linked an issue Nov 4, 2024 that may be closed by this pull request
Copy link
Author

@armansarder armansarder left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I didnt mean to do this so i attempted to delete my changes !

@jpahm
Copy link
Contributor

jpahm commented Nov 8, 2024

I didnt mean to do this so i attempted to delete my changes !

No worries; just a little FYI that you can use git reset --soft to undo changes without losing the work, or git reset --hard to undo changes deleting the work :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Extend context timeout window for "all" endpoint variants
2 participants