Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug]: Allow SPACE to select an autocomplete term without searching #316

Closed
AbhiramTadepalli opened this issue Nov 10, 2024 · 5 comments
Closed
Assignees
Labels
Type: Bug Report Issues pertaining to non-security-related issues Type: User Experience Front facing feature

Comments

@AbhiramTadepalli
Copy link
Contributor

AbhiramTadepalli commented Nov 10, 2024

What did you expect to happen?

If I use the arrow keys to highlight an autocomplete result (after I've typed it out), I want SPACE to select it.

What happened?

Clicking SPACE does not select the autocomplete I've highlighted. Instead:
(a) For 'CS 1200', if I highlight 'CS 1200.HON' and click SPACE, it selects 'CS 1200'

@AbhiramTadepalli AbhiramTadepalli added Type: Bug Report Issues pertaining to non-security-related issues Type: User Experience Front facing feature labels Nov 10, 2024
@AbhiramTadepalli
Copy link
Contributor Author

Here's the deal: Pretty soon ENTER will initiate a new search. ENTER also selects the autocomplete term you have navigated to using arrow keys. I wanted a way to replace ENTER's functionality without causing a new search.
However, I realize that SPACE isn't the ideal thing to use because a person may have multiple names (first, middle, last).
TAB is an accessibility key, idt we should mess with that.

So @TyHil if you can't find a way to do this I'm fine closing the issue

@AbhiramTadepalli AbhiramTadepalli changed the title [Bug]: [Bug]: Allow SPACE to select an autocomplete term without searching Nov 10, 2024
@TyHil
Copy link
Member

TyHil commented Nov 11, 2024

I suppose there could be a plus button on the right of each search result that would add it without doing a new search?

@AbhiramTadepalli
Copy link
Contributor Author

I could try to make clicking not automatically search

But anything we can do from the keyboard?

@TyHil
Copy link
Member

TyHil commented Nov 11, 2024

I can't think of anything from the keyboard

I feel like clicking and ENTER should have the same functionality tho

@AbhiramTadepalli
Copy link
Contributor Author

Okay sure. That's how it will be once #298 is merged in

@AbhiramTadepalli AbhiramTadepalli closed this as not planned Won't fix, can't repro, duplicate, stale Nov 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Type: Bug Report Issues pertaining to non-security-related issues Type: User Experience Front facing feature
Projects
None yet
Development

No branches or pull requests

2 participants