Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Convert to WP Plugin #7

Open
UVLabs opened this issue Jul 15, 2023 · 1 comment
Open

Convert to WP Plugin #7

UVLabs opened this issue Jul 15, 2023 · 1 comment
Milestone

Comments

@UVLabs
Copy link
Owner

UVLabs commented Jul 15, 2023

Right now Freemius limits the webhooks execution to 10 seconds. This is not ideal since the Mautic API can take a while to process the logic it needs to.

I can foresee that as a mautic install grows, it would take more time to run the processes Coach Freem is asking it to. One such process is to search for a contact when only given the email: https://github.com/UVLabs/coach-freem/blob/1.1.3/includes/Contacts/Base.php#L60

It would be best to save the webhook received by Freemius for later processing instead of trying to run all the logic while the webhook is limited to 10 seconds.

Converting Coach to a plugin will also make it easier to get started with for other Freemius users not big on editing code.

@UVLabs UVLabs added this to the 2.0.0 milestone Jul 15, 2023
@UVLabs
Copy link
Owner Author

UVLabs commented Nov 8, 2023

Somewhat made this better by saving the webhook from freemius and later processing it. This might still be better as a plugin and make it easier to build on

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant