Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

create build action #18

Open
jprosser opened this issue May 4, 2023 · 2 comments
Open

create build action #18

jprosser opened this issue May 4, 2023 · 2 comments

Comments

@jprosser
Copy link
Contributor

jprosser commented May 4, 2023

We no longer have Travis and need to replace with Github Actions here.

@miker985
Copy link
Collaborator

miker985 commented May 4, 2023

I've added this workflow to push new images to GHCR when a "release" is made.

I feel like it's a reasonable solution for explicit releases, but still leaves a gap in "how do we test it before releasing it?"

I was thinking an additional workflow for periodic build + transitory tag like "trunk" would be good to cover that case. "latest" would be technically correct but I'm not sure we want to use that. Thoughts?

@jprosser
Copy link
Contributor Author

Couple toughts here, first we can probably just go with a lock on major for the actions, for example just docker/metadata-action@v4 instead of v4.4.0, for each of the actions since we're already behind on some.

On latest, perhaps just leave that tag manual for the time being, which means anchored on last known good as manually determined by someone. Once tests can prove it to a reasonable degree, then additionally tag that version as latest in the automation if we get that far along with things.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants