Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Can we make "quoting" example compatible with Ethers 6.*? #76

Open
davedavinci opened this issue Mar 29, 2024 · 2 comments
Open

Can we make "quoting" example compatible with Ethers 6.*? #76

davedavinci opened this issue Mar 29, 2024 · 2 comments

Comments

@davedavinci
Copy link

I tried to make it work in a dApp using Ethers 6.11 but there's some breaking stuff in the way Ethers 5 vs 6 handle Contract instances methods, therefore await quoterContract.callStatic.quoteExactInputSingle() could not execute under Ethers 6.
It would be amazing to have an updated version of this, together with a multi-hop quoting example.
Keep up the good work guys.

@LoYeeee
Copy link

LoYeeee commented Apr 27, 2024

await quoterContract.quoteExactInputSingle.staticCall()

@jfbloom22
Copy link

jfbloom22 commented May 23, 2024

@davedavinci I have an example working with Ethers 6.12.1
https://github.com/jfbloom22/uniswap-examples/tree/chor/quote/v3-sdk/quoting/src

Note: my example is targeting the QuoterV2 contract and currently pointed at Base chain.

FYI I found some updated examples here: https://discord.com/channels/597638925346930701/607978109089611786/948847107744333844

Hope it helps!

If this repo shows signs of being maintained, I will gladly make a PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants