Skip to content
This repository has been archived by the owner on Sep 17, 2021. It is now read-only.

Support for latest Vyper compiler #43

Open
dmilla opened this issue Nov 17, 2019 · 4 comments
Open

Support for latest Vyper compiler #43

dmilla opened this issue Nov 17, 2019 · 4 comments

Comments

@dmilla
Copy link

dmilla commented Nov 17, 2019

Hello!

First of all congrats for Uniswap, amazing project!

I'm starting a project that will be using Uniswap, and I've updated both contracts so they compile with latest Vyper version. Before creating a PR, I'd like to first confirm if this will be a relevant change for the project, and if yes what other critical parts of the project will need to be updated accordingly besides contracts source?

Thanks!

@dmilla
Copy link
Author

dmilla commented Nov 27, 2019

I just uploaded code in case someone needs it, you can check related PR #44 .

@haydenadams
Copy link
Contributor

Hey @dmilla thanks for the support!

I appreciate the gesture, but these contracts do not need to be updated, as we are well underway into building Uniswap V2 in Solidity.

I'd rather keep the Vyper code identical to the deployed code of Uniswap V1

@dmilla
Copy link
Author

dmilla commented Nov 28, 2019

Thanks for your answer, wasn't aware of that, I understand your point @haydenadams !

Out of curiosity, why have you choosed to go back to solidity for Uniswap V2? Where can I follow V2 development?

@henry-hz
Copy link

good question, why moving from vyper ?

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants