Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

swap doesnt work with permit2=false #638

Open
sirpy opened this issue Jul 23, 2024 · 0 comments
Open

swap doesnt work with permit2=false #638

sirpy opened this issue Jul 23, 2024 · 0 comments
Labels
bug Something isn't working

Comments

@sirpy
Copy link

sirpy commented Jul 23, 2024

Bug Description
A clear and concise description of the bug.
When setting the flag permit2={false}
The "Review swap" button is always grey.

Steps to Reproduce

  1. set permit2=false in widget
  2. try to perform swap

Expected Behavior
user should be able to swap without permit2

Additional Context
The widget should allow to swap also using old permit but also using the regular approve/swap flow in case wallet doesnt support signTypedData

@sirpy sirpy added the bug Something isn't working label Jul 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

1 participant