Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Strategy variants #147

Closed
kwasniew opened this issue Aug 14, 2023 · 1 comment
Closed

Strategy variants #147

kwasniew opened this issue Aug 14, 2023 · 1 comment
Labels
enhancement New feature or request

Comments

@kwasniew
Copy link

kwasniew commented Aug 14, 2023

Describe the feature request

Unleash has a big shift from the feature environment variants to strategy variants to allow more flexible variants based on constraints and segments.
The strategy variants take precedence over the feature environment variants.

Background

What we do today:
Screenshot 2023-08-14 at 10 04 37
What we want to add on top of existing variants:
Screenshot 2023-08-14 at 10 04 49

There's a video showing new strategy variants in action: Unleash/unleash#1550 (comment)

Solution suggestions

We already have a specification for strategy variants: https://github.com/Unleash/client-specification/blob/main/specifications/16-strategy-variants.json

We already did the migration for other SDKs:

The gist of the solution is to first check if the activation strategy has a variant/multiple variants attached. If so, select one of them. If none of the strategies have variants we fall back to the feature environment variants as before (for backwards compatibility). So in the new world each strategy resolves not just to enabled/disabled but when it's enabled it has some variant data attached. It makes the order of strategies matter.

@kwasniew kwasniew added the enhancement New feature or request label Aug 14, 2023
@pransh15 pransh15 moved this from New to Todo in Issues and PRs Aug 15, 2023
@sighphyre sighphyre moved this from Todo to In Progress in Issues and PRs Aug 23, 2023
@gardleopard
Copy link
Contributor

This is solved in (#148) and released in version 4.5.0.

@github-project-automation github-project-automation bot moved this from In Progress to Done in Issues and PRs Aug 24, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
Archived in project
Development

No branches or pull requests

2 participants