Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

KarateSnoopy #506

Closed
KarateSnoopy opened this issue Aug 30, 2018 · 7 comments
Closed

KarateSnoopy #506

KarateSnoopy opened this issue Aug 30, 2018 · 7 comments
Labels

Comments

@KarateSnoopy
Copy link
Contributor

KarateSnoopy commented Aug 30, 2018

Hey, can you add my repo to the community repo as a submodule and hook it up the build magic?
https://github.com/KarateSnoopy/vcv-karatesnoopy/

Here's the commit hash to use for my plugin's v0.6.1 which works with v0.6 of VCV Rack:
c2b628e2638595852c8e7b566157a299f0c04c8a

Here's the updated manifest:

{
  "name": "KarateSnoopy",
  "author": "KarateSnoopy",
  "license": "MIT",
  "manualUrl": "https://github.com/KarateSnoopy/vcv-karatesnoopy/blob/master/README.md",
  "sourceUrl": "https://github.com/KarateSnoopy/vcv-karatesnoopy",
  "latestVersion": "0.6.1",
  "status": "available"
}

Let me know if you need anything else. Thanks!

@cschol
Copy link
Collaborator

cschol commented Aug 31, 2018

Module does not build: KarateSnoopy/vcv-karatesnoopy#8

Further discussion in the issue above as we want to limit the scope of this issue to the plugin manager integration.

@VCVRack VCVRack deleted a comment from KarateSnoopy Aug 31, 2018
@KarateSnoopy
Copy link
Contributor Author

@cschol
Copy link
Collaborator

cschol commented Aug 31, 2018

No. That version will be updated when Andrew builds the module successfully and it is available in the plugin manager. I did the staging, now it will usually take a few days to get incorporated.

@AndrewBelt
Copy link
Member

Updated build

@KarateSnoopy
Copy link
Contributor Author

@cschol Hey, I ported the KarateSnoopy plugin to v1 at https://github.com/KarateSnoopy/vcv-karatesnoopy/tree/v1. Can you track it at https://github.com/VCVRack/library/projects/1?

Thanks!

@AndrewBelt AndrewBelt reopened this Jun 3, 2019
@cschol
Copy link
Collaborator

cschol commented Jun 3, 2019

plugin.json and slug need update: KarateSnoopy/vcv-karatesnoopy#9

@KarateSnoopy
Copy link
Contributor Author

Thanks @cschol
Fixed. Can you take look again?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
Development

No branches or pull requests

3 participants