Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Assembler uses cdata from last floppy for rendering & laser operation #133

Open
evg-zhabotinsky opened this issue Jul 4, 2015 · 1 comment
Labels

Comments

@evg-zhabotinsky
Copy link
Contributor

When Assembler displays a PCB, it is rendered using cdata that is changed on floppy insert.
If circuit size is increased this way, excMatrix is still small and client crashes on render attempt.

Also, this can be used to cheat Assembler to produce circuit faster and for less resources, by starting it with almost empty circuit and then inserting floppy with a real circuit when it has almost finished.

@Victorious3 Victorious3 added the bug label Jul 4, 2015
@evg-zhabotinsky
Copy link
Contributor Author

I kind of "almost fixed" it, and changed GUI a bit. However, I am not sure if it should actually be this way.

Currently, when you insert floppy (and then maybe remove it) while batch is in processing, it looks this way:
1
Batch size (e.g. 5x) shows up only when a batch is being processed.
The first line shows up (and shifts the second line down) only when the newly inserted floppy is different from one being processed. Due to it appearing only in this case, being grayed out and not having batch size, it should be more or less obvious what it means.
I also tried adding descriptions like "Loaded:" and "In processing:", but they seem to just introduce visual noise, and besides, they currently squeeze IC name out of GUI.

I still suspect that this extra first line is a bit out of place.
However, if it is to be removed, the only consistent alternative I see is to remove the whole feature: internal storage of contents of last inserted floppy. So, new batch will have to be started with floppy in place.

Maybe even more restrictive approach will make sense: just lock floppy inside while batch is in processing, as it can be copied easily in case player needs it somewhere else. This will also require almost no changes to existing code to make it bug-free (unlike the other 2 options I suggest).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants