Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Too many empty lines in Squash commit message #1693

Open
PawelLipski opened this issue Aug 9, 2023 · 1 comment
Open

Too many empty lines in Squash commit message #1693

PawelLipski opened this issue Aug 9, 2023 · 1 comment

Comments

@PawelLipski
Copy link
Collaborator

Just a single newline at the end should be enough.

Also, 3 empty lines between the messages seems to much... I'd only keep 3 lines if there's at least one commit whose message consists of more than just a single ("subject") line. Otherwise, let's keep it at 2 lines (or maybe even one?). Or maybe even discard non-subject lines entirely? Let's see what's GitHub does in its squash commits by default, plus what git rebase --interactive does for squash command.

@PawelLipski
Copy link
Collaborator Author

Hah, I've already fixed the trailing lines, then forgot about it :trollface: https://github.com/VirtusLab/git-machete-intellij-plugin/pull/1665/files#r1214752056

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant