Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Test the REPL with the Scala 3 REPL rather than Ammonite #3210

Open
Gedochao opened this issue Sep 26, 2024 · 0 comments
Open

Test the REPL with the Scala 3 REPL rather than Ammonite #3210

Gedochao opened this issue Sep 26, 2024 · 0 comments
Labels
Ammonite blocked upstream Issues and changes blocked by something in an external project. DX Dev experience enhancement New feature or request internal Internal or build-related changes

Comments

@Gedochao
Copy link
Contributor

Is your feature request related to a problem? Please describe.
We currently test a number of things in our REPL integration tests using Ammonite (see #3209).
As Scala CLI is closely tied with Scala 3 releases and Ammonite is maintained separately, we should uncouple these 2 things.
The way things are, it's hard to guess what works until there's an Ammonite version for a given Scala version ready (which sometimes happens late or not at all, like with Scala 3.4.0/3.4.1)

Describe the solution you'd like
We should test all repl sub-command features via the Scala 3 REPL rather than Ammonite REPL.
The only tests relying on Ammonite should be the ones testing the actual integration.

We should run all REPL tests for Scala 3 using the Scala 3 REPL, rather than Ammonite (except for the tests where we do, in fact, test whether the Ammonite integration works as expected).

Dependencies

Additional context

@Gedochao Gedochao added enhancement New feature or request internal Internal or build-related changes DX Dev experience Ammonite blocked upstream Issues and changes blocked by something in an external project. labels Sep 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Ammonite blocked upstream Issues and changes blocked by something in an external project. DX Dev experience enhancement New feature or request internal Internal or build-related changes
Projects
None yet
Development

No branches or pull requests

1 participant