Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Wallet App opening even if user hits on Cancel #31

Open
quetool opened this issue Sep 25, 2023 · 0 comments
Open

Wallet App opening even if user hits on Cancel #31

quetool opened this issue Sep 25, 2023 · 0 comments

Comments

@quetool
Copy link
Collaborator

quetool commented Sep 25, 2023

Upon requesting to open a Wallet App the wallet is opened even if the user hits Cancel in the Confirm Dialog.
This is because we are throwing an exception instead of just communicating the Cancel action.

Issued line here:
https://github.com/WalletConnect/WalletConnectModalFlutter/blob/7b076a81b86e5be5e9d881fe9e8ebc6886521949/lib/services/utils/url/url_utils.dart#L107C14-L107C14

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant