You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Describe the bug
If there is an error in the SDK after we have sent a response to a request, it is not possible to process a new request until that one has expired.
If any of these send methods throws an error, the cleanup method isn't called and the engine will not have it's state changed from active to idle and thus it will block any new request from being processed.
I'm not sure if the intention is that we are supposed to handle the error in this case or if there is something to be added to the SDK to ensure that the message has been transmitted successfully.
SDK Version (if relevant)
Client: [e.g. JS, Swift, Kotlin]
Version [e.g. 22]
To Reproduce
Steps to reproduce the behavior:
Go to '...'
Click on '....'
Scroll down to '....'
See error
Expected behavior
A clear and concise description of what you expected to happen.
Screenshots
If applicable, add screenshots to help explain your problem.
Desktop (please complete the following information):
OS: [e.g. iOS]
Browser [e.g. chrome, safari]
Version [e.g. 22]
Smartphone (please complete the following information):
Describe the bug
If there is an error in the SDK after we have sent a response to a request, it is not possible to process a new request until that one has expired.
If any of these send methods throws an error, the cleanup method isn't called and the engine will not have it's state changed from
active
toidle
and thus it will block any new request from being processed.walletconnect-monorepo/packages/sign-client/src/controllers/engine.ts
Lines 516 to 520 in 5899f27
I have experienced this error to be thrown locally:
walletconnect-monorepo/packages/sign-client/src/controllers/engine.ts
Lines 1248 to 1249 in 5899f27
I'm not sure if the intention is that we are supposed to handle the error in this case or if there is something to be added to the SDK to ensure that the message has been transmitted successfully.
SDK Version (if relevant)
To Reproduce
Steps to reproduce the behavior:
Expected behavior
A clear and concise description of what you expected to happen.
Screenshots
If applicable, add screenshots to help explain your problem.
Desktop (please complete the following information):
Smartphone (please complete the following information):
Additional context
Error Logs:
The text was updated successfully, but these errors were encountered: