Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[specs] Support "dev" environment for sample apps #151

Open
3 tasks
chadyj opened this issue Feb 28, 2022 · 4 comments
Open
3 tasks

[specs] Support "dev" environment for sample apps #151

chadyj opened this issue Feb 28, 2022 · 4 comments

Comments

@chadyj
Copy link
Contributor

chadyj commented Feb 28, 2022

just received report of a dev trying to use our Swift SDK with the "relay.dev.walletconnect.com" because it was on the example

https://github.com/WalletConnect/WalletConnectSwiftV2/blob/5ea0265d34f18ec48d71fc299adacecdacc904bb/Example/DApp/ClientDelegate.swift#L17

it's not terrible but we should have this default to the production server with some override value that you can change for testing environment

Status

Updated in:

  • JS
  • Swift
  • Kotlin
@sekimondre
Copy link

How should we treat the projectId string in this case? We are currently exposing the dev projectId in code, which I don't know if it could expose a risk, but exposing a production projectId in the example code could add some risk. How sensitive is this data for the example App?

@WalletConnect WalletConnect deleted a comment from sekimondre Apr 4, 2022
@chadyj
Copy link
Contributor Author

chadyj commented Apr 4, 2022

How should we treat the projectId string in this case? We are currently exposing the dev projectId in code, which I don't know if it could expose a risk, but exposing a production projectId in the example code could add some risk. How sensitive is this data for the example App?

Answered in the SDK meeting:

Better to hide from source code.

@chadyj
Copy link
Contributor Author

chadyj commented May 4, 2022

On the Swift call today we discussed Github secrets where we can set variables like project ID to be run with github actions.

Might be helpful? https://docs.github.com/en/actions/security-guides/encrypted-secrets#about-encrypted-secrets

The infra team is using Github Secrets for the api proxy integration tests.

@pedrouid pedrouid changed the title SDK support for dev and test environments Support "dev" environment for sample apps Jun 27, 2022
@pedrouid
Copy link
Contributor

Have separate sample apps for both dev and prod environments with separate relayUrl and projectId as environment variables

@chadyj chadyj transferred this issue from WalletConnect/walletconnect-specs Sep 2, 2022
@chadyj chadyj changed the title Support "dev" environment for sample apps [specs] Support "dev" environment for sample apps Sep 2, 2022
@glitch-txs glitch-txs transferred this issue from WalletConnect/walletconnect-docs Oct 4, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants