Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[specs] Properly handle invalid pending requests originating from a DAPP #152

Open
3 tasks
chadyj opened this issue Feb 28, 2022 · 5 comments
Open
3 tasks

Comments

@chadyj
Copy link
Contributor

chadyj commented Feb 28, 2022

Had this feedback from Unstoppable:

To deliver the first version of WC2 in Unstoppable only needs for WC2 SDK to properly handle invalid pending requests originating from a DAPP.

In other words the SDK on a client side should:

  1. update itself when a request on the DAPP side is cancelled or times out.

  2. the SDK should also notify the client so that invalid requests are removed from the client UI.

Both of the above are required to have a smooth and fast UI on a client side.
btw, same applies to Kotlin. Android integration is planned for the next week.

So, with that in mind, are you able to address the item above in the near future? Should be a quick fix on your end. We can assist as well if you need anything from our end

Status

Updated in:

  • JS
  • Swift
  • Kotlin
@chadyj
Copy link
Contributor Author

chadyj commented Mar 1, 2022

@WalletConnect/sdk-team Who was going to own this proposal? From memory I think it was @jakobuid?

@jakubuid
Copy link
Contributor

jakubuid commented Mar 1, 2022

I don't remember tbh. But the what they say is good improvement on how we handle requests on wallet side.

@jakubuid
Copy link
Contributor

jakubuid commented Mar 1, 2022

Let's come back to this topic after protocol refactor.

@pedrouid
Copy link
Contributor

To be investigated with Swift and Kotlin... if session requests are rejected after 5mins

@chadyj chadyj transferred this issue from WalletConnect/walletconnect-specs Sep 2, 2022
@chadyj chadyj changed the title Properly handle invalid pending requests originating from a DAPP [specs] Properly handle invalid pending requests originating from a DAPP Sep 2, 2022
@llbartekll
Copy link
Contributor

To sum up after SDK meeting:
We can add timestamp to each requests: wc_sessionRequest and wc_authRequest. In 5 minutes requests should expire on both peers. After expiry, rpc history record should be removed and future responses ignored.

this will be a protocol change so should the timestamp be optional first and we could make i required after leaving RC?

@glitch-txs glitch-txs transferred this issue from WalletConnect/walletconnect-docs Oct 4, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants