Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Hard Coded folder access #26

Open
MikeLippincott opened this issue Apr 11, 2023 · 2 comments
Open

Hard Coded folder access #26

MikeLippincott opened this issue Apr 11, 2023 · 2 comments
Assignees
@jenna-tomkinson
Labels
bug Something isn't working

Comments

@MikeLippincott
Copy link
Member

https://github.com/WayScience/pyroptosis_signature/blob/e9537650b0e39a9b9c19df2a47ba3db3eb2f177c/utils/loaddata_utils.py#L102

Could we please make this a dynamic option? I named my folder differently.
@MikeLippincott
Copy link
Member Author

value="Maximum_Images" will break if folder is named anything other than "Maximum_Images"

@jenna-tomkinson jenna-tomkinson self-assigned this Jul 6, 2023
@jenna-tomkinson jenna-tomkinson added the bug Something isn't working label Jul 6, 2023
@jenna-tomkinson
Copy link
Member

@MikeLippincott

I agree this is too hard-coded. I have assigned this to myself so I can make this change in the next PR, thank you for bringing it up.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jenna-tomkinson jenna-tomkinson

Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@MikeLippincott @jenna-tomkinson