New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

subtypeのチェックが甘くて不正な値を入れられてしまう #3

Open

White-Green opened this issue Dec 18, 2021 · 1 comment

Labels

bug

Owner

White-Green commented Dec 18, 2021 •

edited

Loading

ref:
https://twitter.com/White_Green2525/status/1463372015570538500?s=20

同じことが#{value: Number}と#{value: Number | String}とか(Number,)と(Number | String,)とかでも起こる

The text was updated successfully, but these errors were encountered:

White-Green added the bug label

Owner Author

White-Green commented Dec 18, 2021

各値の真の型を保存しておいて、代入などの時にチェックするようにする
その値への参照がただ一つであれば、適宜真の型を書き換える

のセットで良い感じに解決できないかと考え中

VMではVec<Arc<_>>でデータを持ってるのでこれによる参照カウントをいい感じに減らす変更が必要
loadと別にmove命令(メモリ上からスタックへ値をmoveする)をもてばいいかも

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment