Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Change text to secondary on content-heavy pages #5148

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from
Draft

Change text to secondary on content-heavy pages #5148

wants to merge 1 commit into from
+1 −1

Conversation

dhruvkb
Copy link
Member

@dhruvkb dhruvkb commented Nov 5, 2024

Fixes

Fixes #5119 by @obulat

Description

This PR changes the content pages to use text-secondary for the body text, while retaining text-default for the headings.

Testing Instructions

Visit the content pages and see that the text should be a little lighter and less contrasted with the background.

I'll update the snapshots once @fcoveram approves the new designs.

Checklist

  • My pull request has a descriptive title (not a vague title likeUpdate index.md).
  • My pull request targets the default branch of the repository (main) or a parent feature branch.
  • My commit messages follow best practices.
  • My code follows the established code style of the repository.
  • I added or updated tests for the changes I made (if applicable).
  • I added or updated documentation (if applicable).
  • I tried running the project locally and verified that there are no visible errors.
  • I ran the DAG documentation generator (ov just catalog/generate-docs for catalog
    PRs) or the media properties generator (ov just catalog/generate-docs media-props
    for the catalog or ov just api/generate-docs for the API) where applicable.

Developer Certificate of Origin

Developer Certificate of Origin 
Developer Certificate of Origin
Version 1.1

Copyright (C) 2004, 2006 The Linux Foundation and its contributors.
1 Letterman Drive
Suite D4700
San Francisco, CA, 94129

Everyone is permitted to copy and distribute verbatim copies of this
license document, but changing it is not allowed.


Developer's Certificate of Origin 1.1

By making a contribution to this project, I certify that:

(a) The contribution was created in whole or in part by me and I
    have the right to submit it under the open source license
    indicated in the file; or

(b) The contribution is based upon previous work that, to the best
    of my knowledge, is covered under an appropriate open source
    license and I have the right under that license to submit that
    work with modifications, whether created in whole or in part
    by me, under the same open source license (unless I am
    permitted to submit under a different license), as indicated
    in the file; or

(c) The contribution was provided directly to me by some other
    person who certified (a), (b) or (c) and I have not modified
    it.

(d) I understand and agree that this project and the contribution
    are public and that a record of the contribution (including all
    personal information I submit with it, including my sign-off) is
    maintained indefinitely and may be redistributed consistent with
    this project or the open source license(s) involved.

@dhruvkb dhruvkb requested a review from fcoveram November 5, 2024 21:00
@dhruvkb dhruvkb requested a review from a team as a code owner November 5, 2024 21:00
@dhruvkb dhruvkb requested review from krysal and obulat November 5, 2024 21:00
@openverse-bot openverse-bot added 🧱 stack: frontend Related to the Nuxt frontend 🟧 priority: high Stalls work on the project or its dependents ✨ goal: improvement Improvement to an existing user-facing feature 🕹 aspect: interface Concerns end-users' experience with the software labels Nov 5, 2024
@github-actions GitHub Actions
Copy link

github-actions bot commented Nov 5, 2024

Latest k6 run output1

     ✓ status was 200

     checks.........................: 100.00% ✓ 6400      ✗ 0   
     data_received..................: 1.5 GB  8.5 MB/s
     data_sent......................: 837 kB  4.7 kB/s
     http_req_blocked...............: avg=24.81µs  min=1.97µs  med=4.22µs   max=10.09ms p(90)=5.7µs    p(95)=6.18µs  
     http_req_connecting............: avg=20.26µs  min=0s      med=0s       max=10.03ms p(90)=0s       p(95)=0s      
     http_req_duration..............: avg=613.24ms min=27.5ms  med=532.07ms max=2.35s   p(90)=1.1s     p(95)=1.21s   
       { expected_response:true }...: avg=613.24ms min=27.5ms  med=532.07ms max=2.35s   p(90)=1.1s     p(95)=1.21s   
   ✓ http_req_failed................: 0.00%   ✓ 0         ✗ 6400
     http_req_receiving.............: avg=163.77µs min=43.08µs med=123.4µs  max=26.02ms p(90)=192.63µs p(95)=231.41µs
     http_req_sending...............: avg=23.32µs  min=6.98µs  med=20.52µs  max=4.96ms  p(90)=26.33µs  p(95)=28.62µs 
     http_req_tls_handshaking.......: avg=0s       min=0s      med=0s       max=0s      p(90)=0s       p(95)=0s      
     http_req_waiting...............: avg=613.05ms min=27.31ms med=531.8ms  max=2.35s   p(90)=1.1s     p(95)=1.21s   
     http_reqs......................: 6400    36.219664/s
     iteration_duration.............: avg=3.27s    min=1.11s   med=2.73s    max=9.37s   p(90)=6.36s    p(95)=6.64s   
     iterations.....................: 1200    6.791187/s
     vus............................: 8       min=8       max=30
     vus_max........................: 30      min=30      max=30

Footnotes

  1. This comment will automatically update with new output each time k6 runs for this PR ↩

fcoveram
fcoveram approved these changes Nov 6, 2024
View reviewed changes
Copy link
Contributor

@fcoveram fcoveram left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It looks great 🚀

@dhruvkb
Copy link
Member Author

dhruvkb commented Nov 6, 2024

Thanks @fcoveram! I'll update the visual regression testing snapshots then.

@dhruvkb dhruvkb marked this pull request as draft November 6, 2024 15:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fcoveram fcoveram fcoveram approved these changes

@krysal krysal Awaiting requested review from krysal krysal is a code owner automatically assigned from WordPress/openverse-frontend

@obulat obulat Awaiting requested review from obulat obulat is a code owner automatically assigned from WordPress/openverse-frontend

Assignees
No one assigned
Labels
🕹 aspect: interface Concerns end-users' experience with the software ✨ goal: improvement Improvement to an existing user-facing feature 🟧 priority: high Stalls work on the project or its dependents 🧱 stack: frontend Related to the Nuxt frontend
Projects
Openverse PRs
Status: 🚧 Draft
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Text-heavy pages should use text-secondary color for text
3 participants
@dhruvkb @fcoveram @openverse-bot