Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Wappalyzer detection for Web Worker Offloading plugin #1597

Closed
adamsilverstein opened this issue Oct 16, 2024 · 7 comments
Closed

Add Wappalyzer detection for Web Worker Offloading plugin #1597

adamsilverstein opened this issue Oct 16, 2024 · 7 comments
Assignees
Labels
[Plugin] Web Worker Offloading Issues for the Web Worker Offloading plugin. [Type] Feature A new feature within an existing module

Comments

@adamsilverstein
Copy link
Member

Feature Description

Now that https://wordpress.org/plugins/web-worker-offloading/ is live, we should add Wappalyzer detection for it. Opening this issue to track that work.

I noticed we didn't include a generator tag in this plugin, should we go ahead and add that?

Currently we could possibly detect usage with the web-worker-offloading path, but adding a generator tag would make detection cleaner. It might make sense to only add the generator tag when the worker strategy is actually used.

cc: @westonruter

@adamsilverstein adamsilverstein added [Plugin] Web Worker Offloading Issues for the Web Worker Offloading plugin. [Type] Feature A new feature within an existing module labels Oct 16, 2024
@adamsilverstein adamsilverstein changed the title Add Wappalyzer detection for new Web Worker plugin Add Wappalyzer detection for Web Worker Offloading plugin Oct 16, 2024
@westonruter
Copy link
Member

Oh, woops. Not including a generator tag was an oversight. Let's add it.

@westonruter
Copy link
Member

Since Web Worker Offloading is not yet featured in the Features screen in the latest version, there are very few installs of the plugin in the wild. This will change once we release the next version of PL, which would happen at the same time this meta tag from #1598 goes out.

@adamsilverstein adamsilverstein added Good First Issue Issue particularly suitable to be worked on by new contributors and removed Good First Issue Issue particularly suitable to be worked on by new contributors labels Oct 16, 2024
@adamsilverstein
Copy link
Member Author

Oh, woops. Not including a generator tag was an oversight. Let's add it.

I'll create a sub-issue!

@westonruter
Copy link
Member

@adamsilverstein I've opened #1598 to fix this already.

@adamsilverstein
Copy link
Member Author

I've opened #1598 to fix this already.

Perfect, thanks! I can take care of adding the wappalyzer sniff

@adamsilverstein
Copy link
Member Author

I submitted a PR to add the Wappalyzer sniff: HTTPArchive/wappalyzer#71

@adamsilverstein
Copy link
Member Author

PR was merged

@adamsilverstein adamsilverstein closed this as completed by moving to Done 😃 in WP Performance 2024 Oct 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Plugin] Web Worker Offloading Issues for the Web Worker Offloading plugin. [Type] Feature A new feature within an existing module
Projects
Status: Done 😃
Development

No branches or pull requests

2 participants