Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ensure text that is copied using the copy button isn’t encoded #31

Open
aaronjorbin opened this issue Jan 26, 2024 · 2 comments
Open

Comments

@aaronjorbin
Copy link
Member

when I used the copy button on iOS and pasted into the commit, it encoded the text

IMG_1269

This meant that @desrosj didnt get credit for WordPress/grunt-patch-wordpress@59c8032

@aaronjorbin
Copy link
Member Author

I think this might be either iOS specific since I'm not seeing it on chrome on mac

@desrosj
Copy link
Contributor

desrosj commented Jan 31, 2024

I think this might be either iOS specific since I'm not seeing it on chrome on mac

Which browser did you see this in while using iOS?

I also did not experience this on Firefox for Mac on my desktop. I don't think this a blocker for releasing a v1, but I think it's worth calling out in the release announcement. I'd argue that while it's convenient (and I do it too), maintainers probably should not be merging on mobile. Especially now that they'll need to manually review the list for accuracy.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants