Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support version syntax (@v1) #44

Open
desrosj opened this issue Feb 1, 2024 · 3 comments
Open

Support version syntax (@v1) #44

desrosj opened this issue Feb 1, 2024 · 3 comments
Assignees
Labels
[Type] Bug Report Something isn't working

Comments

@desrosj
Copy link
Contributor

desrosj commented Feb 1, 2024

Description

It seems something was missed to make the action available through a specific version syntax (@v1, @v1.0.1, etc.).

For now, it's been reverted back to trunk. As an initial release, this will also help push out any bug fixes more quickly. But long term, repositories should not be running bleeding edge.

Version

v1

Workflow file

No response

Link

https://github.com/desrosj/wordpress-develop/actions/runs/7746224196/job/21123961020?pr=148

@desrosj desrosj added the [Type] Bug Report Something isn't working label Feb 1, 2024
@desrosj desrosj self-assigned this Feb 1, 2024
@ataylorme
Copy link

ataylorme commented Feb 2, 2024

From the GitHub Action workflow syntax doc

You can specify a branch, ref, or SHA in a public GitHub repository.

My recommendation is to:

  1. Create GitHub tags for each new version
  2. Maintain a branch for each major version (e.g. v1).

This will allow users to have the choice of referencing a specific tagged version (e.g. @1.x.x) or referencing the major version branch (e.g. @v1).

@swissspidy
Copy link
Member

Oh I didn't realize @v1 could just be a branch reference! 💡 Seems easier than having a rolling tag.

@desrosj
Copy link
Contributor Author

desrosj commented Feb 6, 2024

Oh I didn't realize @v1 could just be a branch reference! 💡 Seems easier than having a rolling tag.

Same! Thanks @ataylorme. Let's create the v1 branch after we get some more of these issues cleaned up. We're using trunk to test the bleeding edge in Gutenberg/wordpress-develop currently anyway.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Type] Bug Report Something isn't working
Projects
None yet
Development

No branches or pull requests

3 participants