Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add e2e tests for critical paths #497

Open
iandunn opened this issue Nov 18, 2022 · 4 comments
Open

Add e2e tests for critical paths #497

iandunn opened this issue Nov 18, 2022 · 4 comments

Comments

@iandunn
Copy link
Member

iandunn commented Nov 18, 2022

Some things can't be tested well with PHPUnit (like #490), so it could be helpful to have some e2e tests. I don't think they need to be comprehensive, but it'd be nice to cover the critical paths from user and security perspectives.

We might get a head start by looking at what @sjinks did ƒor https://github.com/sjinks/wp-two-factor-provider-webauthn

@jeffpaul
Copy link
Member

jeffpaul commented Mar 2, 2023

@iandunn would it make sense to leverage Playwright like Gutenberg and Core have evolved to do for e2e tests?

@iandunn
Copy link
Member Author

iandunn commented Mar 2, 2023

I haven't used it yet, so I'm open to someone more knowledgeable having a different opinion, but that sounds like a logical approach 👍🏻

It looks like that's also what was done in https://github.com/sjinks/wp-two-factor-provider-webauthn, so we might be able to copy a lot of that.

@sjinks
Copy link
Contributor

sjinks commented Mar 3, 2023

If you need some help, please feel free to ping me :-)

@jeffpaul
Copy link
Member

@sjinks if you're familiar with Playwright tests, then you can take a look at how WordPress core and Gutenberg both utilize that for their e2e tests and work on an initial PR to add those tests & GitHub Action for the Two-Factor plugin:

Thanks!
Jeff.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants