You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Currently, we have two types of notices: Notice and GlobalNotice.
A Notice is a prompt box that appears in various positions within each component. It could be an error notice, or a warning, info, success notice, etc.
GlobalNotice, on the other hand, is a black prompt box that pops up in a fixed position in the top right corner. Its message is set through setGlobalNotice.
We could consider consolidating these two to enhance readability.
The text was updated successfully, but these errors were encountered:
Yeah, that's a good point. Originally, I thought there were probably some reasons for naming it as GlobalNotice so I figured it could reduce confusion by merging the two components. But it looks like we could directly replace GlobalNotice with Snackbar, or these GlobalNotice and Notice naming would be likely to cause some misunderstanding for someone new to the code or when we come back to look at the code after a while.
Currently, we have two types of notices:
Notice
andGlobalNotice
.A
Notice
is a prompt box that appears in various positions within each component. It could be an error notice, or a warning, info, success notice, etc.GlobalNotice
, on the other hand, is a black prompt box that pops up in a fixed position in the top right corner. Its message is set throughsetGlobalNotice
.We could consider consolidating these two to enhance readability.
The text was updated successfully, but these errors were encountered: