Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Should additional methods always be indicated as not completed? #302

Open
pkevan opened this issue Aug 21, 2024 · 9 comments
Open

Should additional methods always be indicated as not completed? #302

pkevan opened this issue Aug 21, 2024 · 9 comments
Labels
question Further information is requested

Comments

@pkevan
Copy link
Contributor

pkevan commented Aug 21, 2024

Screenshot 2024-08-21 at 08 26 24

In the above screenshot, it would appear like it's expected (by the user) to have TOTP and backup codes - pretty sure it's expected that an additional backup method is set, but not two.

@pkevan pkevan added the question Further information is requested label Aug 21, 2024
@StevenDufresne
Copy link
Contributor

StevenDufresne commented Aug 26, 2024

Ideally we have as many factors configured on an account.

However, we also received feedback during a walkthrough that the "x"'s icons were intense.

@pkevan
Copy link
Contributor Author

pkevan commented Aug 27, 2024

Perhaps a non-red icon could be used to indicated Not configured rather than required.

@StevenDufresne
Copy link
Contributor

We could move to the warning|info icon.

@StevenDufresne
Copy link
Contributor

Here are some options:

@WordPress/meta-design Thoughts on updating the UI for yet-to-be-configured factors?

Option A
Screenshot 2024-08-28 at 10 13 50 AM

Option B
Screenshot 2024-08-28 at 10 11 22 AM

Option C
Screenshot 2024-08-28 at 10 10 23 AM

Option D
Screenshot 2024-08-28 at 10 15 46 AM

@jasmussen
Copy link
Collaborator

Two options:

checklist-1 checklist

These move the help-text to the right, adjusts it a little, and allow that help text to serve as confirmation or a prompt. With or without color can work.

Rather than using destructive red to imply you really should be using 2fa, I'd rather we increase the prominence of the suggestion text. A third option:

checklist

In the above mockups, there's a little less space used than what's shipping, so there should be room in the final version to make the text still more verbose, if need be.

@StevenDufresne
Copy link
Contributor

I like those explorations. Thanks for the thoughtful takes.

I think the timing may not be right to make such a drastic change as most of our communication has gone out (recently) and it includes many screenshots of the current UI. I think the options you've presented do add some subtle and interesting improvements, but I think for now I would prefer we implement minimal changes while we help the remaining users configure their 2fa.

I'm inclined to just change the color and use a friendlier icon for now. @pkevan Thoughts?

@jasmussen
Copy link
Collaborator

A smaller change can work. I don't know the color change is really meaningful, though, I'd hade to see a red splotch next to a security key if I'm never going to add one.

@pkevan
Copy link
Contributor Author

pkevan commented Sep 2, 2024

I'm inclined to just change the color and use a friendlier icon for now. @pkevan Thoughts?

I somehow wonder if we're attempting to do this wrong by putting everything on the same screen when in fact we want users to have 2 out of 3 setup? Should 2 Factor methods (key, totp, backup) be it's own screen?

Either way, we need it to be clear what is or isn't required, and anything with red or a x appears like we want more from the user, and you start reading Two Factor XXX and tune out as a user and look for the simplest path to compliance 😁

@StevenDufresne
Copy link
Contributor

That's a good point, see #291.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
question Further information is requested
Projects
None yet
Development

No branches or pull requests

3 participants