Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Booking rules emails fire in primary id order - not by timecreated #761

Open
danbuntu opened this issue Dec 11, 2024 · 2 comments
Open

Booking rules emails fire in primary id order - not by timecreated #761

danbuntu opened this issue Dec 11, 2024 · 2 comments
Assignees

Comments

@danbuntu
Copy link

Is your feature request related to a problem? Please describe.
If you have two rules setup in the following order:

Booking Confirmed
Booking Cancelled

You then cancel the booking for a user and immediately rebook them they will recieve the emails in the same order. So in outlook etc which shows email recent to latest they show as:

Booking Cancelled
Booking Confirmed

This is potentally very confusing for an end user.

Describe the solution you'd like
Emails should be sent in the order they were created/ triggered if possble and ignore the order in the UI.

Likewise if the order they appear in is important there should be the option to reorder them in the UI. Perhaps also the use of an 'orderby' colum. Currently the only way to reorder them is to directly edit the primary key.

@eynimeni
Copy link
Contributor

Hi,

the rules create adhoc tasks in the order of the events with the nextruntime of the tasks set for now. So usually the triggered actions (like sending mails) should be executed in the order of the actions in the UI.
Maybe your cron job executed the jobs in another order?

@danbuntu
Copy link
Author

I haven't done anything special to the cronjob. It's useful to know that they are being created as hoc jobs though as this is something I'll look into.
I'll look to retest this in the new year, hopefully when #656 is completed and rules can fire by booking option date.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants