Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

custom filter: Improvements #149

Open
4 tasks
dasistwas opened this issue Jan 18, 2021 · 2 comments
Open
4 tasks

custom filter: Improvements #149

dasistwas opened this issue Jan 18, 2021 · 2 comments
Assignees

Comments

@dasistwas
Copy link
Member

dasistwas commented Jan 18, 2021

Current status: When in the view settings the tag '##pagingbar##' is included and I use a custom filter, then the paging bar does not show up due to lack of limitation to set entries per page.

  • In custom filter settings add possibility to define per page setting like on the regular filters
  • Make sure paging bar shows up
  • Display number of filtered entries / total entries
  • Sort order is not respected. Make sort order work again.
@michaelpollak
Copy link
Collaborator

Steps:
I create a view with pagingbar and custom filter
I select 1 in the Per page menu
I search for something in the customfilter - works
I sort by some field, works also
I click on the pagingbar page 2 and filters are gone - fails

So here pagingbar actually shows up when using customfilters but does not work properly. Am looking into that.

@michaelpollak
Copy link
Collaborator

I've been working on this for a few days now without much progress. Customfilter is in big parts incompatible with filter and pagination does not work as expected bc. data is not passed.

To get the number of total entries we need to build a separate query without customfilter, this is a huge overhead.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants