Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Paging bar: not functional #155

Open
dasistwas opened this issue Feb 10, 2021 · 5 comments
Open

Paging bar: not functional #155

dasistwas opened this issue Feb 10, 2021 · 5 comments
Assignees
Labels

Comments

@dasistwas
Copy link
Member

It seems the paging bar is not working. When there is more than 1 page, and I click on page 2, nothing happens. (Added a filter with default of 10 entries per page, 15 entries total)

@dasistwas
Copy link
Member Author

tested with datalynxcoursepage: https://github.com/Wunderbyte-GmbH/moodle-mod_datalynxcoursepage

@michaelpollak
Copy link
Collaborator

Tested and can't reproduce with normal datalynx, will check out the datalynxcoursepage later.
Parameters in the url are something like this: &filter=1234&page=2 and output is as expected.

@dasistwas
Copy link
Member Author

dasistwas commented Feb 11, 2021

Could you try with that course backup:

https://nx811.your-storageshare.de/s/di9M48eQnDcyDPD

@michaelpollak
Copy link
Collaborator

Ah got it, thanks for the backup David!
Bug only appears when we force a filter for the user as in this case we ignore the passed URL parameters. The pagingbar feature works via the URL parameters, so there's the problem. Will get back to you when it's fixed.

michaelpollak added a commit to michaelpollak/moodle-mod_datalynx that referenced this issue Feb 11, 2021
@michaelpollak
Copy link
Collaborator

Fixed and tested, see my commit.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants