Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: replace defunct weather API with Open-Meteo #25

Merged
merged 7 commits into from
Jul 29, 2024
Merged

fix: replace defunct weather API with Open-Meteo #25

merged 7 commits into from
Jul 29, 2024

Conversation

Ste1io
Copy link
Contributor

@Ste1io Ste1io commented Jul 21, 2024 •
edited
Loading

  • Replaced original weather API with Open-Meteo, removing need for API key
  • Implemented geocoding for location lookup using city or postal code, and setting location directly with latitude and longitude instead of zmw
  • Added config file versioning
  • Changed metric flag type to bool; valid config ini values are now "true/false", "yes/no", "1/0" (case-insensitive)
  • Added improved error handling and user notifications
  • Updated configuration management to save new keys in settings.ini
  • Refactored UI updates for weather conditions and forecasts
  • Includes helper functions for weather code lookup, wind direction conversion, date handling, and ini file error handling
  • Added documentation comments

fixes #21

Ste1io added 7 commits July 16, 2024 16:25
@Ste1io
fmt Weather script, no code changes
d469aa7
@Ste1io
fix broken weather api (api key no longer needed)
0b3aef9 
- replace original (now defunct) api implementation with open-meteo
- convert zmw location lookup system with lat,lon geocords using geocoding api for city/zip lookup
- implement more robust error handling
- updated keys saved in configuration ini
- add doc comments
@Ste1io
minor changes to improve code structure and readability
126b026
@Ste1io
code readability, cleanup:
5b128c7 
- consistent lua syntax with semicolon usage
@Ste1io
add config file versioning, fix 1-based indexing bug
ec11f75 
create helper functions to reduce duplicate error handling code

rename command from "location" to "reset_location"
@Ste1io
display wind speed units without slash (mp/h =>MPH)
f735c59
@Ste1io
refactor metric config flag to be treated and saved as bool not integer:
31d7203 
- valid config ini values are now "true/false", "yes/no", "1/0" (case-insensitive)
@Ste1io Ste1io merged commit 31d7203 into master Jul 29, 2024
@Ste1io
Copy link
Contributor Author

Ste1io commented Jul 29, 2024

Something went spaztastic on me and this got merged prematurely. Opening new PR with remaining changes.

@Ste1io Ste1io deleted the Ste1io/issue21 branch July 29, 2024 22:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Swizzy Swizzy Swizzy left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

weather forecast
2 participants
@Ste1io @Swizzy