From 81b69a7e734ba08674cc593d835676f7e8aad03e Mon Sep 17 00:00:00 2001 From: Evan Krall Date: Wed, 10 Jan 2024 14:31:45 -0800 Subject: [PATCH 1/2] Mention check_autoscaler_max_instances alert name in the documentation about it, to make it more searchable. --- docs/source/autoscaling.rst | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/docs/source/autoscaling.rst b/docs/source/autoscaling.rst index 7933e404dc..71bc77e96a 100644 --- a/docs/source/autoscaling.rst +++ b/docs/source/autoscaling.rst @@ -149,7 +149,7 @@ attempt to autoscale your service with the default autoscaling method. ``max_instances`` alerting -------------------------- -In order to make you aware of when your ``max_instances`` may be too low, causing issues with your service, paasta will send you alerts if all of the following conditions are true: +In order to make you aware of when your ``max_instances`` may be too low, causing issues with your service, Paasta will send you ``check_autoscaler_max_instances`` alerts if all of the following conditions are true: * The autoscaler has scaled your service to ``max_instances``. From c80c16ae802eed25a129bb35991b8af477ac325c Mon Sep 17 00:00:00 2001 From: Evan Krall Date: Thu, 11 Jan 2024 11:53:55 -0800 Subject: [PATCH 2/2] Realert once an hour for check_autoscaler_max_instances --- paasta_tools/check_autoscaler_max_instances.py | 1 + 1 file changed, 1 insertion(+) diff --git a/paasta_tools/check_autoscaler_max_instances.py b/paasta_tools/check_autoscaler_max_instances.py index e1cd4c8c0f..e6d464b4ba 100755 --- a/paasta_tools/check_autoscaler_max_instances.py +++ b/paasta_tools/check_autoscaler_max_instances.py @@ -136,6 +136,7 @@ async def check_max_instances( { "page": False, # TODO: remove this line once this alert has been deployed for a little while. "runbook": "y/check-autoscaler-max-instances", + "realert_every": 60, # The check runs once a minute, so this would realert every hour. "tip": ( "The autoscaler wants to scale up to handle additional load" " because your service is overloaded, but cannot scale any"