Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improved documentation #10

Open
jguhlin opened this issue Apr 12, 2021 · 2 comments
Open

Improved documentation #10

jguhlin opened this issue Apr 12, 2021 · 2 comments

Comments

@jguhlin
Copy link

jguhlin commented Apr 12, 2021

Hello, is it possible to get some additional documentation? For example, I do not know what he, he-ai, brent models are. Same for MR, SR, BF. Also, are the defaults always the first possible argument? So MLM is the default model?

Cheers,
--Joseph

@YinLiLin
Copy link
Owner

Hi Joseph,

Thank you for the question.
Sorry about that, I will add more descriptive details for some major parameters of KAML on the README page, before that, I would like to give a rough explanation about the parameters you mentioned above. "he", "he-ai" and "brent" are the options of algorithms for variance components estimation, "he" represents HE regression, it's super fast, but less of accuracy and stability, "he-ai" represents AIREML with prior values provided by HE regression, and 'brent' is a method of interval estimation of heritability, is more efficient than AIREML by aid of Eigen decomposition technology on genomic relationship matrix. We recommend using "brent", as it has the most stable performance from our large data testing by far. "MR", "SR" and "BF" are the options of how to choose the posterior QTNs, "MR" represents multiple regression, "SR" represents step regression, and "BF" represents using Bonferroni threshold directly.
You are right, if no parameters are specified, KAML will use the first argument for each parameters, "MLM" is the default model, you can find the final used option of each parameters from the printed LOG information.

Best,
Lilin

@jguhlin
Copy link
Author

jguhlin commented Jun 7, 2021

Thanks for the explanations here. It's much appreciated. I'm working on a smaller dataset so the options are very important to adjust.

Cheers,
--Joseph

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants